search

glaszig / SZTextView

A drop-in UITextView replacement which gives you: a placeholder.
MIT License
682 stars 102 forks source link

Swift rewrite #53

Closed Jmeggesto closed 7 years ago

Jmeggesto commented 7 years ago

Rewrite of SZTextView into Swift, for people who might not want to integrate Objective-C into their codebase

glaszig commented 7 years ago

great work. thanks. however, i'm quite hesitant merging this and changing the default language to swift because this might break older build systems people are running. also, using objective-c with swift is rather easy by way of using a bridging header. using objective-c on old systems with swift, on the other hand, does not work, afaik.

i'd encourage you to maintain your fork as a seperate project, possibly renaming it to something like "SZTextView.swift" -- what do you think?

Jmeggesto commented 7 years ago

Yeah, absolutely - I apologize, I had no intention of it becoming the default version, just an option for people who might want to go pure Swift. I don't often contribute to open source so I figured I'd just PR to the master branch. If you're okay with me maintaining a separate fork, i can totally do that.

Thanks for getting back to me!

On Sun, Nov 6, 2016 at 3:06 PM, glaszig notifications@github.com wrote:

great work. thanks. however, i'm quite hesitant merging this and changing the default language to swift because this might break older build systems people are running. also, using objective-c with swift is rather easy by way of using a bridging header https://developer.apple.com/library/content/documentation/Swift/Conceptual/BuildingCocoaApps/MixandMatch.html. using objective-c on old systems with swift, on the other hand, does not work, afaik.

i'd encourage you to maintain your fork as a seperate project, possibly renaming it to something like "SZTextView.swift" -- what do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/glaszig/SZTextView/pull/53#issuecomment-258706704, or mute the thread https://github.com/notifications/unsubscribe-auth/AMBISDUu4tWEb4ayyA_hG5WIwHfdehxHks5q7jNcgaJpZM4Khyet .

glaszig commented 7 years ago

If you're okay

i am. this is MIT-licensed code.