search

glaumar / QRookie

Download and install Quest games from ROOKIE Public Mirror (like VRP Rookie Sideloader but for Linux and MacOS)
GNU General Public License v3.0
39 stars 4 forks source link

macOS version looks very ugly #23

Closed MikeRatcliffe closed 3 months ago

MikeRatcliffe commented 3 months ago

The Material Design on macOS looks very ugly... especially when it comes to button placements. The app looks much better on macOS using the Universal Design (see below).

Also notice the random missing info in the Games Tab (in the VRFlow game details)... seems like the Material Design is quite buggy.

Material Design - Games Tab

Material Theme - Games Tab

Universal Design - Games Tab

Universal Theme - Games Tab

Material Design - Downloads Tab

Material Theme - Downloads Tab

Universal Design - Downloads Tab

Universal Theme - Downloads Tab

Material Design - Devices Tab

Material Theme - Devices Tab

Universal Design - Devices Tab

Universal Theme - Devices Tab
victorwads commented 3 months ago

What do you think @glaumar?

A personally prefer Material, or any darker theme. But i found universal theme a lot similar, but the Tabs Layout are confusing cause there is no indicator about the current tab.

I think that is personal and could be set on Settings. Could u add this to settings and start the user selected theme on main script? @MikeRatcliffe

glaumar commented 3 months ago

Users can use the QT_QUICK_CONTROLS_STYLE environment variable to set the theme used by QRookie.

I think Universal is better because it is very similar to the breeze theme used in Linux, and the original UI design of QRookie was done under breeze.

However, @victorwads, you are the main maintainer of the Darwin part, and the final decision is yours

glaumar commented 3 months ago

Another problem with the MacOS version is that it does not follow the system light/dark theme. The Linux version uses org.kde.breeze which will follow the system light/dark theme at runtime, but I was not able to compile/install it successfully in nix-darwin

MikeRatcliffe commented 3 months ago

@glaumar & @victorwads

I'll add it to the settings dialog... my understanding is that the Universal theme is the most consistent across platforms.

Kirigami is tested with qqc2-desktop-style, and to a lesser extent with qqc2-breeze-style (on Plasma Mobile and Android). With other styles like Material or Universal it tends to be quite broken.

Dark theming is a mess, especially on osx... I'd love to implement it, but to do that, it would be best if we had a consistent theme across platforms because Material, in particular, has its quirks e.g. Material offsets buttons by 6px to make room for button shadows, which is the reason for the ugliness I mentioned above. If we correct for Material, then other themes are broken. Also, the dark colors don't tend to propagate properly.

Another problem with a dark theme is that, in Material, disabled buttons are dark with dark text and the colors can't be changed (I created a dark theme, but needed to add hacks everywhere so I dropped it).

Anyhow, I'm rambling now, so I'll do some stuff and then get back to this ;)