gleam-lang / language-tour

👩🏽‍💻 Learn Gleam in your browser
https://tour.gleam.run/
82 stars 62 forks source link

Interactive coding editor formatting issues #112

Closed simon-curtis closed 3 months ago

simon-curtis commented 4 months ago

I'm jotting this down as I will fix it but am not at my PC

As per @lpil on the YouTube stream Gleam v1.2.0 is out now!!! at 27:13 the warning box has some min-height issue where it's causing the output box to show a scroll bar instead of filling the space.

Also, the editor and output on mobile seem to be collapsed and unusable.

Without testing it looks like the change was made here: fix hidden code editor

simon-curtis commented 3 months ago

Warnings and errors now don't have 100% height, this prevents the false output scroll and allows multiple errors/warnings.

image

And, I have given the editor a min-height of 15rem to give a bit of space for mobile

image