Add dark mode support - Githubissues

gleam-lang / language-tour

👩🏽‍💻 Learn Gleam in your browser

https://tour.gleam.run/

82 stars 62 forks source link

Add dark mode support #26

Closed ffigiel closed 7 months ago

ffigiel commented 7 months ago

Closes #6

I had to disable default colorscheme in Codeflask to make it look nice in the dark mode, so there's no highlighting in the editor

Todo:

[x] Add theme picker, dark mode is currently hard-coded
[x] Do we want to fix syntax highlighting in this PR?

ffigiel commented 7 months ago

New screenshots

localhost_8000_basics_hello-world_ (1)

lpil commented 7 months ago

Are you happy with where this is now @ffigiel ?

ffigiel commented 7 months ago

Are you happy with where this is now @ffigiel ?

I'm not sure if we want to keep the common.css file now that it doesn't have a "source of truth" for the latest version since the branding repo was archived, what do you think we should do?
I'm not happy with the contrast on the dark theme editor but it's not that terrible and it makes sense to handle that in a separate issue/PR

Overall I think you could merge it

ffigiel commented 7 months ago

actually I just noticed we could get rid of the off-brand underwater-blue-dark color if we used black for inline code background instead (like the codeblocks on the website), let me fix that quickly and we're good update: done