search

gleam-lang / language-tour

👩🏽‍💻 Learn Gleam in your browser
https://tour.gleam.run/
73 stars 55 forks source link

feat: :lipstick: adds css print media rules for everything page #90

Closed xxKeefer closed 2 months ago

xxKeefer commented 2 months ago

for /everything page of the tour to be printed as a multi page pdf doc

closes #71

lpil commented 2 months ago

oops sorry, I clicked "approve" by mistake

xxKeefer commented 2 months ago

Hey there @lpil, Sorry i should have checked FireFox, upon further investigation it appears @media print is scuffed on FireFox, I can not get it to respect any of the page break media and it wouldn't even do multiple pages until i chucked a * { overflow: visible !important; } on it.

I'm not prepared to go on a deeper dive on this one, this pr at least gives people on chromium browsers an option to print it.

I should also note i don't have access to a machine that can run safari so i cannot confirm if this works for apple users.

lpil commented 2 months ago

I'm afraid we cannot accept browser specific functionality so this cannot be merged without a fix.

xxKeefer commented 2 months ago

As it turns out, when it's not two in the morning in my local and after a good nights sleeps i was prepared for deep diving. In hindsight of course it should work on all browsers i don't know what i was thinking 🤦🏻 .

inoas commented 2 months ago

wow this looks so great!