In this PR I removed some other @target annotations from:
bit_array.inspect, this required a really small change to the js implementation but nothing special
string.reverse, this one I'm not super sure about: I removed the specialised javascript implementation and used the one leveraging string_builder, the difference is it's adding two new calls to the identity function. If this poses any performance concerns (I'm not sure it does) then I can revert this one!
So with this PR stdlib doesn't have any needless target annotation remaining. The only remaining one are totally reasonable and cannot really be removed:
In tests to check the behaviour of different targets
In set to choose an appropriate type for the token for each target
Some remaining ones in the bit_array module, needed to work around the lack of support for some segment options in the js target
In this PR I removed some other
@targetannotations from:bit_array.inspect, this required a really small change to the js implementation but nothing specialstring.reverse, this one I'm not super sure about: I removed the specialised javascript implementation and used the one leveragingstring_builder, the difference is it's adding two new calls to the identity function. If this poses any performance concerns (I'm not sure it does) then I can revert this one!So with this PR stdlib doesn't have any needless target annotation remaining. The only remaining one are totally reasonable and cannot really be removed:
setto choose an appropriate type for the token for each targetbit_arraymodule, needed to work around the lack of support for some segment options in the js target