search

gleam-lang / tree-sitter-gleam

🌳 A tree-sitter grammar for the Gleam programming language
Apache License 2.0
71 stars 13 forks source link

Highlighting broken in gleam/test/language #35

Closed TanklesXL closed 2 years ago

TanklesXL commented 2 years ago

Highlighting seems to be broken in the gleam core language tests:

https://github.com/gleam-lang/gleam/blob/0f20f6f46fa9c9e4baa6f264dd49e59ecbd9b0a5/test/language/src/main.gleam#L84

It looks like it stops after 0., so it could be that floats without values after the decimal aren't being parsed properly

the-mikedavis commented 2 years ago

I think this is #30?

lpil commented 2 years ago

Ah yes, seems likely. Do we need to do anything to get GitHub updated?

TanklesXL commented 2 years ago

Yeah looks like it, why is it still happening 🤔 is it waiting for a new GitHub release or something?

the-mikedavis commented 2 years ago

Running the latest commit against that files looks good. I think the parser just needs to be updated on GitHub's end. @patrickt is this something I can bother you about? 🙂

patrickt commented 2 years ago

Yup, no problem. Will rev it now.

patrickt commented 2 years ago

@the-mikedavis It’s revved. The original linked revision is still in some front-end cache somewhere, so you’ll need to wait for that particular instance to fall out of cache, but you can see it working in this past revision.

the-mikedavis commented 2 years ago

Looks perfect, thanks @patrickt!

lpil commented 2 years ago

Thank you!!