gleam-wisp / wisp

🧚 A practical web framework for Gleam
https://gleam-wisp.github.io/wisp/
Apache License 2.0
914 stars 41 forks source link

Update `gleam_json` dependency constraint #82

Closed giacomocavalieri closed 1 month ago

lpil commented 4 months ago

What's the motivation here? I thought we were deliberately holding back on this one?

giacomocavalieri commented 4 months ago

Oops sorry I had no idea it was being intentionally held back. My problem is I ran into dependency resolution errors trying to add lustre_dev_tools as a dependency:

> gleam new wibble
> cd wibble
> gleam add lustre
> gleam add lustre_dev_tools --dev

error: Dependency resolution failed

An error occurred while determining what dependency packages and
versions should be downloaded.
The error from the version resolver library was:

Unable to find compatible versions for the version constraints in your
gleam.toml. The conflicting packages are:

- wibble
- lustre_dev_tools
- wisp
- gleam_json

The error message is not super useful but I thought the problem might be with wisp being too restrictive with the constraint.

lpil commented 4 months ago

Brew is stuck on 26 for some reason so if we upgrade everything to the new gleam_json most macOS users won't be able to use them. This is why Lustre docs are saying to use the old version of gleam_json currently. Looks like you've installed the new one there.

pmbanugo commented 2 months ago

I guess this can be fixed/merged, Erlang OTP on homebrew mac is now on 27. I guess that's the blocker, according to this comment

Papipo commented 2 months ago

Why would someone prefer to use brew over something like asdf? I mean, can't just asdf be recommended over brew?

giacomocavalieri commented 2 months ago

Even if we recommended asdf it wouldn't change the fact that loads of macOS users will be using brew and breaking a really common library for them would be quite bad.

Personally I use brew and like how simple it is :)

lpil commented 2 months ago

Would you mind rebasing on main please 🙏

giacomocavalieri commented 1 month ago

Done!

lpil commented 1 month ago

Sorry Jak, I merged another PR that had this change also

giacomocavalieri commented 1 month ago

No worries!