search

glebdmitriew / node-unzip-2

node.js cross-platform unzip using streams
MIT License
44 stars 39 forks source link

Extract fails when a filesize of 0 bytes is encountered. #2

Open smithandweb opened 9 years ago

smithandweb commented 9 years ago

Same for Parse. Tested by writing white space to empty files and Parse and Extract worked as expected. Function stops at first encounter.

austinhallock commented 9 years ago

The problem seems to be in the Pullstream lib: https://github.com/EvanOxfeld/node-pullstream/blob/master/pullstream.js#L64

changing that to if (len === null) { fixes it on our end

antonydb commented 9 years ago

:+1: Thanks @austinhallock . Solved my issue :)

jakubknejzlik commented 9 years ago

I've already created pull request for pullstream ... hope they will merge it soon.

feiyuw commented 8 years ago

+1 thanks @austinhallock . You solved my issue.