search

gleborgne / molvwr

WebGL molecule viewer made with Babylon.js
http://gleborgne.github.io/molvwr/
Other
33 stars 8 forks source link

"atom not found" and "dataReadyCallback is not a function" #1

Open kittykatattack opened 7 years ago

kittykatattack commented 7 years ago

Hello,

Your example of how to embed the molecule viewer on a website produces this error:

screen shot 2017-08-15 at 1 19 17 pm

http://gleborgne.github.io/molvwr/embedexample.html

Is there a simple solution to this?

Thanks!

kittykatattack commented 7 years ago

Just letting you know I've found the bug. Line 199 in molvwr-bundle.js should read:

if(dataReadyCallback) dataReadyCallback(molecule);
ArtyshkoAndrey commented 5 years ago

Просто сообщаю, что я нашел ошибку. В строке 199 molvwr-bundle.jsследует читать:

if(dataReadyCallback) dataReadyCallback(molecule);

Hey. Modeling to help me with one project, I have a similar idea but only on threejs, everything is loaded for a very long time, and he has it quickly. I would like to increase the rendering speed. 30-40 atoms half a minute opens, and he instantly at babylonjs

ArtyshkoAndrey commented 5 years ago

Просто сообщаю, что я нашел ошибку. В строке 199 molvwr-bundle.jsследует читать:

if(dataReadyCallback) dataReadyCallback(molecule);

Hey. Modeling to help me with one project, I have a similar idea but only on threejs, everything is loaded for a very long time, and he has it quickly. I would like to increase the rendering speed. 30-40 atoms half a minute opens, and he instantly at babylonjs

my gmail artyshko.andrey@gmail.com