search

glebpineparks / job-postings

Jobs for WordPress
GNU General Public License v3.0
5 stars 5 forks source link

change cpt slug from translatable to static string #9

Open cfoellmann opened 5 years ago

cfoellmann commented 5 years ago

$post_type_slug = apply_filters('jobs_post_type/slug', _x('job', 'jobs_slug', 'job-postings')); using a non-static string for the cpt slug is a bad idea.

Problem now is that if an update changes this to a static string job for all languages all non-english websites that have a translations file for the plugin will lose all entries for this cpt. There needs to be backwards compatibility

glebpineparks commented 5 years ago

@cfoellmann we dont have translation for this in translation files much I remember... But anyway probably a good idea to make it static

cfoellmann commented 5 years ago

For one of the next versions we need to be a migration tool to change all existing entries to jobs! If more languages become available through language packs there is a significant risk here to "wipe" all entries from a users site. Supporting this will be a pain