glebpopoff
commented
12 years ago Not sure if I like this approach. Let me think about this..I may want to somehow expand it on the list view or allow the user to see the full title w/o bringing up the context menu
On Wed, Feb 22, 2012 at 3:22 AM, suan < reply@reply.github.com
wrote:
I've seen reviews complaining that article titles are being truncated, and its annoyed me too, so here's my solution... make sure they fit in the dialog title when you long-click on one.
I've tried to keep the look and feel as "stock Android" as possible, but because the built-in dialog title styles are not exposed, if in the future they change, my style assumptions might make it look weird...
Most of the commits are from my earlier ".gitignore" pull request. If you merge that in first you should see a clean diff for this one.
You can merge this Pull Request by running:
git pull https://github.com/suan/Hacker-News-Droid-Appmake_context_menu_fit_title
Or you can view, comment on it, or merge it online at:
https://github.com/glebpopov/Hacker-News-Droid-App/pull/9
-- Commit Summary --
- gitignore generated files
- custom news fragment long click title view to accomodate long titles
-- File Changes --
A .gitignore (2) D bin/HackerNewsDroid.apk (0) D bin/classes.dex (0) D bin/com/glebpopov/hackernews/AskActivity.class (0) D bin/com/glebpopov/hackernews/BestActivity.class (0) D bin/com/glebpopov/hackernews/CommentsActivity.class (0) D bin/com/glebpopov/hackernews/MainActivity$1.class (0) D bin/com/glebpopov/hackernews/MainActivity.class (0) D bin/com/glebpopov/hackernews/NewestActivity.class (0) D bin/com/glebpopov/hackernews/PreviewActivity.class (0) D bin/com/glebpopov/hackernews/R$anim.class (0) D bin/com/glebpopov/hackernews/R$array.class (0) D bin/com/glebpopov/hackernews/R$attr.class (0) D bin/com/glebpopov/hackernews/R$color.class (0) D bin/com/glebpopov/hackernews/R$dimen.class (0) D bin/com/glebpopov/hackernews/R$drawable.class (0) D bin/com/glebpopov/hackernews/R$id.class (0) D bin/com/glebpopov/hackernews/R$layout.class (0) D bin/com/glebpopov/hackernews/R$menu.class (0) D bin/com/glebpopov/hackernews/R$raw.class (0) D bin/com/glebpopov/hackernews/R$string.class (0) D bin/com/glebpopov/hackernews/R$style.class (0) D bin/com/glebpopov/hackernews/R$styleable.class (0) D bin/com/glebpopov/hackernews/R$xml.class (0) D bin/com/glebpopov/hackernews/R.class (0) D bin/com/glebpopov/hackernews/SavedActivity.class (0) D bin/com/glebpopov/hackernews/domain/CommentItem.class (0) D bin/com/glebpopov/hackernews/domain/NewsItem.class (0) D bin/com/glebpopov/hackernews/fragments/CommentsFragment$1.class (0) D bin/com/glebpopov/hackernews/fragments/CommentsFragment$2.class (0) D bin/com/glebpopov/hackernews/fragments/CommentsFragment$CommentsItemAdapter.class (0) D bin/com/glebpopov/hackernews/fragments/CommentsFragment.class (0) D bin/com/glebpopov/hackernews/fragments/NewsFragment$1.class (0) D bin/com/glebpopov/hackernews/fragments/NewsFragment$2.class (0) D bin/com/glebpopov/hackernews/fragments/NewsFragment$3.class (0) D bin/com/glebpopov/hackernews/fragments/NewsFragment$4.class (0) D bin/com/glebpopov/hackernews/fragments/NewsFragment$5.class (0) D bin/com/glebpopov/hackernews/fragments/NewsFragment$6.class (0) D bin/com/glebpopov/hackernews/fragments/NewsFragment$NewsItemAdapter.class (0) D bin/com/glebpopov/hackernews/fragments/NewsFragment.class (0) D bin/com/glebpopov/hackernews/fragments/PreviewFragment$1.class (0) D bin/com/glebpopov/hackernews/fragments/PreviewFragment$2.class (0) D bin/com/glebpopov/hackernews/fragments/PreviewFragment.class (0) D bin/com/glebpopov/hackernews/fragments/SavedNewsFragment$1.class (0) D bin/com/glebpopov/hackernews/fragments/SavedNewsFragment$2.class (0) D bin/com/glebpopov/hackernews/fragments/SavedNewsFragment$3.class (0) D bin/com/glebpopov/hackernews/fragments/SavedNewsFragment$4.class (0) D bin/com/glebpopov/hackernews/fragments/SavedNewsFragment$5.class (0) D bin/com/glebpopov/hackernews/fragments/SavedNewsFragment$NewsItemAdapter.class (0) D bin/com/glebpopov/hackernews/fragments/SavedNewsFragment.class (0) D bin/com/glebpopov/hackernews/net/DataParser.class (0) D bin/com/glebpopov/hackernews/net/InstapaperIntegration.class (0) D bin/com/glebpopov/hackernews/service/HackerNewsService.class (0) D bin/com/glebpopov/hackernews/service/HackerNewsWidgetProvider.class (0) D bin/com/glebpopov/hackernews/settings/AboutPreference$1.class (0) D bin/com/glebpopov/hackernews/settings/AboutPreference.class (0) D bin/com/glebpopov/hackernews/settings/ClearInstapaperLogin.class (0) D bin/com/glebpopov/hackernews/settings/ClearSavedContent.class (0) D bin/com/glebpopov/hackernews/settings/EditPreferences.class (0) D bin/com/glebpopov/hackernews/settings/WarrantyPreference$1.class (0) D bin/com/glebpopov/hackernews/settings/WarrantyPreference.class (0) D bin/com/glebpopov/hackernews/ui/BaseActivity.class (0) D bin/com/glebpopov/hackernews/ui/BaseSinglePaneActivity.class (0) D bin/com/glebpopov/hackernews/util/ActivityHelper$1.class (0) D bin/com/glebpopov/hackernews/util/ActivityHelper$2.class (0) D bin/com/glebpopov/hackernews/util/ActivityHelper.class (0) D bin/com/glebpopov/hackernews/util/AppSettings.class (0) D bin/com/glebpopov/hackernews/util/DatabaseUtil.class (0) D bin/com/glebpopov/hackernews/util/EncryptionUtil.class (0) D bin/com/glebpopov/hackernews/util/FileCache.class (0) D bin/com/glebpopov/hackernews/util/ImageLoader$BitmapDisplayer.class (0) D bin/com/glebpopov/hackernews/util/ImageLoader$PhotoToLoad.class (0) D bin/com/glebpopov/hackernews/util/ImageLoader$PhotosLoader.class (0) D bin/com/glebpopov/hackernews/util/ImageLoader$PhotosQueue.class (0) D bin/com/glebpopov/hackernews/util/ImageLoader.class (0) D bin/com/glebpopov/hackernews/util/ImageLoaderUtils.class (0) D bin/com/glebpopov/hackernews/util/MemoryCache.class (0) D bin/com/glebpopov/hackernews/util/SimpleMenu.class (0) D bin/com/glebpopov/hackernews/util/SimpleMenuItem.class (0) D bin/resources.ap_ (0) D gen/com/glebpopov/hackernews/R.java (740) A res/layout/news_fragment_dialog_title.xml (10) M src/com/glebpopov/hackernews/fragments/NewsFragment.java (4)
-- Patch Links --
https://github.com/glebpopov/Hacker-News-Droid-App/pull/9.patch https://github.com/glebpopov/Hacker-News-Droid-App/pull/9.diff
Reply to this email directly or view it on GitHub: https://github.com/glebpopov/Hacker-News-Droid-App/pull/9
Gleb Popov
suan
I've seen reviews complaining that article titles are being truncated, and its annoyed me too, so here's my solution... make sure they fit in the dialog title when you long-click on one.
I've tried to keep the look and feel as "stock Android" as possible, but because the built-in dialog title styles are not exposed, if in the future they change, my style assumptions might make it look weird...
Most of the commits are from my earlier ".gitignore" pull request. If you merge that in first you should see a clean diff for this one.