search

gleclaire / findbugs-maven-plugin

Maven Mojo Plug-In to generate reports based on the FindBugs Analyzer
https://gleclaire.github.io/findbugs-maven-plugin/
Apache License 2.0
57 stars 93 forks source link

Findbugs aggregate report #77

Open spyhunter99 opened 7 years ago

spyhunter99 commented 7 years ago

Just an FYI, I did find a way to make a find bugs aggregate report. https://github.com/spyhunter99/FindBugsAggregate

I just prints a table of the counts of all child modules and links to the actual report

hazendaz commented 7 years ago

@spyhunter99 checkstyles maven plugin aggregates today (somewhat anyways). So wouldn't it be possible to build this into this plugin so that at the end of the multi module run it has all the data already collected and would produce that report under the target of the main parent module? Would you be able to create such a pull request into this plugin? I see this as extremely useful.

spyhunter99 commented 7 years ago

ha that's why i was giving you all a heads up. The maven reporting plugin infrastructure doesn't appear to support requiring child modules to do their thing before a parent module. I'm not entirely sure how checkstyle did it.

hazendaz commented 7 years ago

I know theirs is not perfect but might be worth taking a look. It seems to though some false positives on that end but is good enough I guess. I would like to see this come in here even if it is not 100%. The 80/20 rule is good enough for me ;) We can work on making it 100%.

spyhunter99 commented 7 years ago

they probably runs the check at the parent module and includes the src of all child modules. That's fine for check style, but findbugs needs the classpath of all child modules. From a maven perspective, i think that's only available during the execution of the child modules. This would mostly work in some cases but far from all cases and in the end, the analysis task of findbugs would be ran twice (it's already slow)