search

gleero / grunt-favicons

Generate favicon.ico and icons for iOS, Android and WP8
MIT License
233 stars 48 forks source link

use sync-exec instead of execSync, fixes problem with Node 0.12 #53

Closed marten-seemann closed 9 years ago

marten-seemann commented 9 years ago

As suggested in https://github.com/mgutz/execSync/issues/38#issuecomment-73771651, replacing execSync by sync-exec solves a problem occurring with Node 0.12. Will also fix #52.

marten-seemann commented 9 years ago

@mgutz What's the status on that?

mgutz commented 9 years ago

I put a notice on execSync project's readme that it is no longer maintained. I advise everyone to use sync-exec instead.

marten-seemann commented 9 years ago

Thank you, @mgutz, then I think this PR does exactly as you advised. @gleero: Is there any reason not to merge this PR?