search

gleero / grunt-favicons

Generate favicon.ico and icons for iOS, Android and WP8
MIT License
233 stars 48 forks source link

Error: Cannot find module 'sync-exec' #54

Closed marten-seemann closed 9 years ago

marten-seemann commented 9 years ago

I messed up the dependencies and devDependencies in my last PR. Sorry for that. This PR resolves this bug.

In detail, the bug was, that sync-exec was only registered under devDependencies, thus it would not be installed when installing this package using npm install or so.

marten-seemann commented 9 years ago

@gleero: Is there any reason not to merge this PR? When you do, please also increase the version number, otherwise the module version that can be installed via NPM still remains unusable with the latest Node version.

viktorbijlenga commented 9 years ago

How can I help to get this PR merged?

marten-seemann commented 9 years ago

I'm afraid this can only be done by @gleero.

viktorbijlenga commented 9 years ago

I reminded @gleero on Twitter about this a few hours ago. It might help a bit. Lets see. In the meantime I'm using your forked version.

marten-seemann commented 9 years ago

Thanks, @gleero. Please keep in mind that you have to increase the version number to make this change available to everyone using this package.

viktorbijlenga commented 9 years ago

Thanks @gleero!