gleitz / howdoi

instant coding answers via the command line
http://blog.gleitzman.com/post/43330157197/howdoi-instant-coding-answers-via-the-command-line
MIT License
10.56k stars 867 forks source link

Not installable in python3.5 #472

Closed benatouba closed 1 year ago

benatouba commented 1 year ago

What happened:

howdoi does not install with python 3.5

What you expected to happen:

The documentation says that it would work with python3.5 or above

The setup.py includes f-strings which were introduced in python3.6. This leads to the following stacktrace:

Collecting howdoi
  Using cached https://files.pythonhosted.org/packages/6d/43/0e8166583575bd500c0f8f1a4ab9429af9466feb6fcdc006e88de8fd23e9/howdoi-2.0.20.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-_sykpfkw/howdoi/setup.py", line 29
        'Pylint': f'pylint howdoi {local_python_files_str} --rcfile=.pylintrc'.split()}
                                                                             ^
    SyntaxError: invalid syntax

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-_sykpfkw/howdoi/
gleitz commented 1 year ago

Thanks for the report. Unfortunately due to lack of f-string support howdoi requires at least python 3.6.

benatouba commented 1 year ago

Thanks. I just reported this because the documentation says python3.5 and above.

gleitz commented 1 year ago

Ah, I would accept a PR to fix the docs!