Closed CaedenPH closed 1 year ago
@gleitz Pinging for review
@gleitz The first commit was a mistake :eyes: Apologies
What do you think about the tradeoffs between putting the check inside the howdoi
function, vs a check on the argparse library?
If someone really wanted to look up howdoi c
(perhaps for c programming) should we allow that?
What do you think about the tradeoffs between putting the check inside the
howdoi
function, vs a check on the argparse library?If someone really wanted to look up
howdoi c
(perhaps for c programming) should we allow that?
What is the output of howdoi c
? Does it actually provide a useful output?
At the moment it's not very useful. It was more of a question of whether we want to put this range check at the command line level with argparse, and allowing any people who use howdoi as a library to continue to do so without limitations.
In practice it probably doesn't matter, just an interesting philosophical question of command line vs. library level range checks.
At the moment it's not very useful. It was more of a question of whether we want to put this range check at the command line level with argparse, and allowing any people who use howdoi as a library to continue to do so without limitations.
In practice it probably doesn't matter, just an interesting philosophical question of command line vs. library level range checks.
Ah, I see what you mean. Now that you raise the point, I think command line would actually be better to allow for more library control
Description:
471
Pull Request type:
How to test:
Please provide detailed instructions for testing your changes locally, including expected response/behavior.
Any one word query with less than 2 letters should error
Pull Request checklist:
nose2
).python setup.py lint
)..env
included.