search

gleitz / midi-js-soundfonts

Pre-rendered General MIDI soundfonts that can be used immediately with MIDI.js
http://blog.gleitzman.com/post/63283830260/midi-js-playing-audio-in-the-browser-with-javascript
MIT License
678 stars 148 forks source link

Links in README.md do not work #13

Closed ghost closed 7 years ago

ghost commented 7 years ago

Hi, and first thanks for these sounds. Maybe you could merge master branch in gh-pages, and choose gh-pages as the default branch, maybe then remove master.

gleitz commented 7 years ago

Good idea. Looks like I need to follow these steps.

gleitz commented 7 years ago

Done.

ghost commented 7 years ago

Ok Now gh-pages is the default however it seems that you haven't merged master in gh-pages before providing gh-pages as default. So the json files, and links in readme have gone. Do you still have the master branch on your local machine in order to merge and push?

gleitz commented 7 years ago

Ah good point. Merged in https://github.com/gleitz/midi-js-soundfonts/pull/14

ghost commented 7 years ago

Now it's OK thanks.