search

gleitz / midi-js-soundfonts

Pre-rendered General MIDI soundfonts that can be used immediately with MIDI.js
http://blog.gleitzman.com/post/63283830260/midi-js-playing-audio-in-the-browser-with-javascript
MIT License
678 stars 148 forks source link

Little things to fix #2

Closed iFeelPixel closed 10 years ago

iFeelPixel commented 10 years ago

Hello, here is the issues I have found so far.

Lets start by missing Underscore:

Removing Underscore:

Renaming sound name:

Sincerely

gleitz commented 10 years ago

Excellent! Would you mind submitting a pull request?

gleitz commented 10 years ago

Are you sure it shouldn't be:

Rename "synthstrings_1" to "synth_strings_1" in files synth_strings_1-ogg and synth_strings_1-mp3 (with the "s")

Pulling the sound file names from MIDI.GeneralMIDI.byName I get:

accordion: Object
acoustic_bass: Object
acoustic_grand_piano: Object
acoustic_guitar_nylon: Object
acoustic_guitar_steel: Object
agogo: Object
alto_sax: Object
applause: Object
bagpipe: Object
banjo: Object
baritone_sax: Object
bassoon: Object
bird_tweet: Object
blown_bottle: Object
brass_section: Object
breath_noise: Object
bright_acoustic_piano: Object
celesta: Object
cello: Object
choir_aahs: Object
church_organ: Object
clarinet: Object
clavinet: Object
contrabass: Object
distortion_guitar: Object
drawbar_organ: Object
dulcimer: Object
electric_bass_finger: Object
electric_bass_pick: Object
electric_grand_piano: Object
electric_guitar_clean: Object
electric_guitar_jazz: Object
electric_guitar_muted: Object
electric_piano_1: Object
electric_piano_2: Object
english_horn: Object
fiddle: Object
flute: Object
french_horn: Object
fretless_bass: Object
fx_1_rain: Object
fx_2_soundtrack: Object
fx_3_crystal: Object
fx_4_atmosphere: Object
fx_5_brightness: Object
fx_6_goblins: Object
fx_7_echoes: Object
fx_8_scifi: Object
glockenspiel: Object
guitar_fret_noise: Object
guitar_harmonics: Object
gunshot: Object
harmonica: Object
harpsichord: Object
helicopter: Object
honkytonk_piano: Object
kalimba: Object
koto: Object
lead_1_square: Object
lead_2_sawtooth: Object
lead_3_calliope: Object
lead_4_chiff: Object
lead_5_charang: Object
lead_6_voice: Object
lead_7_fifths: Object
lead_8_bass__lead: Object
marimba: Object
melodic_tom: Object
music_box: Object
muted_trumpet: Object
oboe: Object
ocarina: Object
orchestra_hit: Object
orchestral_harp: Object
overdriven_guitar: Object
pad_1_new_age: Object
pad_2_warm: Object
pad_3_polysynth: Object
pad_4_choir: Object
pad_5_bowed: Object
pad_6_metallic: Object
pad_7_halo: Object
pad_8_sweep: Object
pan_flute: Object
percussive_organ: Object
piccolo: Object
pizzicato_strings: Object
recorder: Object
reed_organ: Object
reverse_cymbal: Object
rock_organ: Object
seashore: Object
shakuhachi: Object
shamisen: Object
shanai: Object
sitar: Object
slap_bass_1: Object
slap_bass_2: Object
soprano_sax: Object
steel_drums: Object
string_ensemble_1: Object
string_ensemble_2: Object
synth_bass_1: Object
synth_bass_2: Object
synth_brass_1: Object
synth_brass_2: Object
synth_choir: Object
synth_drum: Object
synth_strings_1: Object
synth_strings_2: Object
taiko_drum: Object
tango_accordion: Object
telephone_ring: Object
tenor_sax: Object
timpani: Object
tinkle_bell: Object
tremolo_strings: Object
trombone: Object
trumpet: Object
tuba: Object
tubular_bells: Object
vibraphone: Object
viola: Object
violin: Object
voice_oohs: Object
whistle: Object
woodblock: Object
xylophone: Object
iFeelPixel commented 10 years ago

Sorry for the delay of answer. Yes, you are right, I forgot to put the "S". I edited the issue.

If the instrument name "lead_8_bass__lead" is correct, you just have to rename the folder or the filename.

Thanks for the list, it will be useful to compare it. I don't understand exactly how to submit a pull request. So I prefer let you do it.

gleitz commented 10 years ago

Check out the guide here -> https://help.github.com/articles/using-pull-requests#initiating-the-pull-request

In a nutshell you're going to want to have your own fork of the code, commit the changes, and then click the "Compare & review" button on your branch. At that point it will get sent to me for review.

gleitz commented 10 years ago

Let me know if that makes sense. Otherwise I'll make the changes by hand.

iFeelPixel commented 10 years ago

Please make the changes by hand. By the way, we've added sound feedback in Tactile Mobile app using MIDI.js library and your pre-generated soundfonts! You can try our multimodal interface at https://play.google.com/store/search?q=ifeelpixel Thanks again.