search

gleitz / midi-js-soundfonts

Pre-rendered General MIDI soundfonts that can be used immediately with MIDI.js
http://blog.gleitzman.com/post/63283830260/midi-js-playing-audio-in-the-browser-with-javascript
MIT License
678 stars 148 forks source link

MIDI Instrument Renaming #20

Closed DoomTay closed 7 years ago

DoomTay commented 7 years ago

Attempts to fix #19

gleitz commented 7 years ago

Sweet. Given my understanding of the bug the instruments might not have worked properly before. Is it possible that this fix will break existing implementations? If so what's the best way for them to update?

DoomTay commented 7 years ago

This has been tested with "manually" changing instruments via MIDI.programChange and playing MIDI files, and both work fine without changing anything. I don't know if anything else would be impacted.