search

gleitz / midi-js-soundfonts

Pre-rendered General MIDI soundfonts that can be used immediately with MIDI.js
http://blog.gleitzman.com/post/63283830260/midi-js-playing-audio-in-the-browser-with-javascript
MIT License
691 stars 151 forks source link

[doc] readme: update link to soundfont-generator #22

Closed mk-pmb closed 7 years ago

mk-pmb commented 7 years ago

Hi there, I'm looking for ways to convert a custom sf2, so I followed the "soundfont-generator" link in the readme but it's broken (404). How can I convert it?

Update: Found it. Now this issue is just about updating the readme.

gleitz commented 7 years ago

Would you submit a PR with the corrected links? Thx!

mk-pmb commented 7 years ago

Ok, I'm on it. Would you like a package.json for npm as well? Update: Oops, that git-clone will take a few hours. Maybe I can PR tomorrow. Update: Found how to use git sparse checkout. Update 2: Still very large. :-(

gleitz commented 7 years ago

Lol yeah it's a pretty big repo. A package.json is not a bad idea. No rush and thanks for the help.

mk-pmb commented 7 years ago

As for the package.json, there seems to be a license conflict between MIT in LICENSE.txt and the CC-BY-SA-3.0 of Musyng Kite, how should I resolve it?

gleitz commented 7 years ago

Which of the two licenses (Creative Commons Attribution 3.0 license and Creative Commons Attribution Share-Alike 3.0 license) would both fall into? Let's go with that one.

mk-pmb commented 7 years ago

In my layman interpretation (I'm not a lawyer) of CC-BY-SA-3.0 and MIT, their works cannot be unified into a work with just one license. I'll make a package.json with bogus license field for now, then someone else can easily update it once the legal stuff is resolved.

gleitz commented 7 years ago

Cool thx.

On Sun, Aug 20, 2017 at 12:15 PM M.K. notifications@github.com wrote:

In my layman interpretation (I'm not a lawyer) of CC-BY-SA-3.0 and MIT, their works cannot be unified into a work with just one license. I'll make a package.json with bogus license field for now, then someone else can easily update it once the legal stuff is resolved.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gleitz/midi-js-soundfonts/issues/22#issuecomment-323605479, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYH9uOSy2o5A9_OUsi3dGXB0TddKahCks5saIW_gaJpZM4O8qoI .