search

glejeune / Ruby-Graphviz

[MIRROR] Ruby interface to the GraphViz graphing tool
https://gitlab.com/glejeune/ruby-graphviz
Other
608 stars 116 forks source link

Fix gemspec #146

Closed deivid-rodriguez closed 4 years ago

deivid-rodriguez commented 4 years ago

I noticed that the gem fails to be built on current master like this:

$ gem build ruby-graphviz.gemspec
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from ruby-graphviz.gemspec:23.
NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It will be removed on or after 2018-12-01.
Gem::Specification#has_rdoc= called from ruby-graphviz.gemspec:24.
WARNING:  See https://guides.rubygems.org/specification-reference/ for help
ERROR:  While executing gem ... (Gem::InvalidSpecificationException)
    ["AUTHORS.rdoc", "CHANGELOG.rdoc", "COPYING.rdoc", "README.rdoc"] are not files

This PR fixes the gemspec so that it can be built again, and it also adds a few other tiny improvements to it.

Closes #141.

deivid-rodriguez commented 4 years ago

Thanks for the merge @glejeune!

Any chance of a release any time soon? I'm particularly interested in #144 because that would fix some errors we're getting in bundler when running our specs against ruby's master.

deivid-rodriguez commented 4 years ago

Thanks for the release! :)