glektarssza / minecraft-expanded-gamerules

A Minecraft mod that adds a bunch of new gamerules for easier customization.
https://modrinth.com/mod/expanded-gamerules
MIT License
2 stars 1 forks source link

[bug] Mod crashes on Minecraft 1.19.2 (Forge) #89

Closed glektarssza closed 2 months ago

glektarssza commented 2 months ago

Description

Mod does not work on Minecraft 1.19.2 when using Forge.

Steps to Reproduce

  1. Use Minecraft 1.19.2 with Forge

Expected Behavior

Actual Behavior

Operating System

Windows

Java Version

N/A

Mod Loader

Forge

Minecraft Version

1.19.2

Mod Version

0.3.3

Launcher

N/A

Mod Portal

CurseForge

Additional Information

Imported from https://legacy.curseforge.com/minecraft/mc-mods/expanded-gamerules?comment=5

Original text:

hi y`y have a crash report for the forge version of your mod for minecraft 1.19.2 https://textup.fr/792777jb (for the crash report) can y fix it?

sorry for my english

Disclaimer

glektarssza commented 2 months ago

Looks like this line is wrong for 1.19.2 compared to later versions of 1.19.x since Forge saw a major version bump between 1.19.2 and 1.19.3+

Solution is to split 1.19.2 and 1.19.3+ into separate branches and recompile as separate builds.

glektarssza commented 2 months ago

Fixed with the release of v0.3.4 for Forge.