search

glenco / SLsimLib

Library for Gravitational Lensing Simulations
MIT License
2 stars 1 forks source link

LensHaloBaseNSIE #132

Closed rbmetcalf closed 7 years ago

rbmetcalf commented 7 years ago

Does this class ever need to be constructed by itself? If not we should block it. Jen-Wei found that when she used it in this way the kappa was 10x too small. @FabienNugier what do you think?

FabienNugier commented 7 years ago

Hi, sorry for the very late reply. LensHaloBaseNSIE is supposed to be a parent class I think. On my side I use LensHaloFit’s constructor which uses it, but never LensHaloBaseNSIE’s constructor. So you think there is a mistake in force() of LensHaloBaseNSIE ?

Best regards, Fabien

On 4 Jul 2017, at 11:08 PM, Ben Metcalf notifications@github.com wrote:

Does this class ever need to be constructed by itself? If not we should block it. Jen-Wei found that when she used it in this way the kappa was 10x too small. @FabienNugier https://github.com/fabiennugier what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/glenco/SLsimLib/issues/132, or mute the thread https://github.com/notifications/unsubscribe-auth/AG1NHhxzbEcSODwS1RlhaA5QD61R0cRvks5sKlV2gaJpZM4ONdzI.

rbmetcalf commented 7 years ago

In pull request #138 LensHaloBaseNSIE is made into an abstract class so that only classes derived from it can be instantiated.