glenco / SLsimLib

Library for Gravitational Lensing Simulations
MIT License
2 stars 1 forks source link

Fixing centring and rotation of LensHaloParticles #159

Closed rbmetcalf closed 4 years ago

rbmetcalf commented 4 years ago

@gdespali I have made some changes that I thing solve the problems you contacted me about. I think the problem was that the halo was been rotated about a point that wasn't the correct one.

Can you check out this pull request and see if your problems go away?

gdespali commented 4 years ago

Hi @rbmetcalf sorry for the delay. I updated my local glamer and tried. But for the same code I now get an error with the grid which is:

ray: /u/gdespali/glamer/SLsimLib/FullRange/internal_rayshooter_multi.cpp:294: void compute_rays_parallel(void): Assertion `alpha[0] == alpha[0] && alpha[1] == alpha[1]' failed.

At the grid creation with Grid grid(&lens,100,center.x,range);

Not sure if it could be related to these changes?