search

glencoesoftware / bioformats2raw

Bio-Formats image file format to raw format converter
GNU General Public License v2.0
77 stars 35 forks source link

Remove the "--pixel-type" option #173

Closed melissalinkert closed 1 year ago

melissalinkert commented 1 year ago

Fixes #154.

As described in #154, --pixel-type never worked quite right, and we now have other ways to solve the problems it was meant to fix. This removes the option entirely (no deprecation), but could be changed to keep the option a no-op if anyone feels strongly.

Maybe worth including in the next patch release along with https://github.com/glencoesoftware/bioformats2raw/pull/171#pullrequestreview-1163027738?

sbesson commented 1 year ago

we now have other ways to solve the problems it was meant to fix.

Is this primarily referring to the min/max calculation per channel which is now happening by default in bioformats2raw 0.5.0? From a client perspective, this should definitely make it easier to rescale the data without having to modify the pixel type during conversion.

This removes the option entirely (no deprecation), but could be changed to keep the option a no-op if anyone feels strongly.

Re-reading the original issue, I think we are talking about a data loss issue which is arguably one of the worst kind in a conversion library. I would also support dropping the option entirely.