glencoesoftware / bioformats2raw

Bio-Formats image file format to raw format converter
GNU General Public License v2.0
82 stars 36 forks source link

Fix progress and help options #234

Closed melissalinkert closed 10 months ago

melissalinkert commented 10 months ago

As discussed earlier today with @sbesson and @chris-allan.

With this change, commands similar to:

$ bioformats2raw --help
$ bioformats2raw -p --foo test.fake test.zarr
$ bioformats2raw -p --help

should print a usage message and exit.

I don't know why the help flag was set for -p/--progress-bars, maybe @joshmoore remembers from the initial implementation in #83?

raw2ometiff will need a similar update once we're happy with the state of this PR.

joshmoore commented 10 months ago

Uff. My guess is that it was a copy-n-paste error.

melissalinkert commented 10 months ago

Can we use the standard options for --help?

Main reason I didn't do that here was that we already define -h as the short option for setting the tile height.