reuse jetty configuration rather than add jettyEmbed?

glenford / xsbt-war-plugins

A set of war related plugins for xsbt (sbt 0.10+)

Apache License 2.0

9 stars 2 forks source link

reuse jetty configuration rather than add jettyEmbed? #2

Open smparkes opened 13 years ago

smparkes commented 13 years ago

I'm wondering if there's any reason not to just reuse the "jetty" configuration from the webapp plugin, rather than create another jettyEmbed configuration? Maybe I'm not using all the functionality available, but in my project, they're always the same ...

smparkes commented 13 years ago

Actually, let me rephrase this: what about including everything in "jetty" as well as in "jettyEmbed" in embedJettyPrepare? I do actually have at least one jar that I don't load within "jetty" that I do want to explode in the war. But I dont have the converse: anything that I want within sbt that I don't want in the war.

smparkes commented 13 years ago

c.f. https://github.com/smparkes/xsbt-web-plugin/commit/c78cca606cc0d79ad568bda076fb069e22b7f9ed