Closed philipp-spiess closed 6 years ago
I'm afraid I don't really have time to look into React 16 compatibility myself at the moment. Although, I will have time to review/merge/publish any PRs relating to this stuff.
If someone can produce a failing testcase for React 16 that would be really helpful as a starting point for anyone investigating this.
Fixed by #94 - released in v1.2.0
I'm in the process of upgrading our application to use the latest React version and we're facing issues with
skin-deep
.It seems that other people already had success with the upgrade (c.f. #91), but I receive the following stack trace:
From a first look, it seems like:
https://github.com/glenjamin/skin-deep/blob/d734f91fed26a3451f3e35e4b244c055ba8cdd4c/skin-deep.js#L40
is
undefined
for me.If I remove the second
._instance
it seems to work (although some tests are failing which might be due to the fact thatshallowRender
will no longer callcomponentDidUpdate
, c.f. https://facebook.github.io/react/blog/2017/09/26/react-v16.0.html).Here are the two lines about shallow rendering in the React 16 blog post, I'm not sure if that helps: