search

glenjamin / transit-immutable-js

Transit serialisation for Immutable.js
MIT License
250 stars 31 forks source link

implement `missingRecordHandler` #19

Closed freakinruben closed 8 years ago

freakinruben commented 8 years ago

solves #18

What do you think of this implementation?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling addea14f5e609edb24ca925405701a834d289e4d on vita-io:feature/solve-non-existing-records-manually into 712b450b74d423c9b9ab3137b791739f7bad1644 on glenjamin:master.

glenjamin commented 8 years ago

Looks broadly sensible to me, just needs the lint warnings fixing 🙂

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling afb30c97ebcf7690f38f5c21a188158bef308c94 on vita-io:feature/solve-non-existing-records-manually into 712b450b74d423c9b9ab3137b791739f7bad1644 on glenjamin:master.

freakinruben commented 8 years ago

Done. Let me know if you would like it implemented somewhere else or differently

glenjamin commented 8 years ago

I've just spotted that the withFilter function needs to pass the new option along too.

If you add that in I can merge & release - if not I'll probably sort it myself this evening

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3d47ecb98f89d612ad0e369682be8e71e26dcc3d on vita-io:feature/solve-non-existing-records-manually into 712b450b74d423c9b9ab3137b791739f7bad1644 on glenjamin:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a82ffaef320939637b5c7ad809599b3b5da0acd2 on vita-io:feature/solve-non-existing-records-manually into 712b450b74d423c9b9ab3137b791739f7bad1644 on glenjamin:master.

glenjamin commented 8 years ago

Ok, that's published as v0.6.0 - thanks for the contribution!

freakinruben commented 8 years ago

You're fast! Thanks

On 08 May 2016, at 19:56, Glen Mailer notifications@github.com wrote:

Ok, that's published as v0.6.0 - thanks for the contribution!

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub