search

glenngnng / pe

0 stars 0 forks source link

Hard to understand error message for redo command #10

Open glenngnng opened 10 months ago

glenngnng commented 10 months ago

image.png

This hinders the user as they may not understand what it means due to poor grammar.

nus-se-script commented 9 months ago

Team's Response

Thank you for your suggestion! We acknowledge that there is a slightly incorrect grammar there: "need" -> "needs", but we don't think it hinders users' understanding. Therefore, we classify this bug as not in scope.

If you didn't read the UG quite thoroughly, "the employee list" means the whole list of employees that filled more than 80% of your screen. "The command to be redone" is the command you just undo, e.g., delete -> undo -> redo: you want to redo the "delete". This command needs to modify the employee list in order for the user to be able to redo it. If we include all this explanation in the app or in the UG, it will make our app/UG complete but rather unprofessional, wordy, and redundant because all the terms used in the error message have been explained in the UG. Therefore, we will keep the concise error message as it is and fix "need" -> "needs", so we will classify this bug as not in scope because according to the PE guidelines, we consider this grammar issue to be far less important than the whole redo feature.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Hm, there are two grammatical errors here, which causes more hindrance to the user. "need" -> "needs" and "modified" -> "modify".

However, I don't think this is not in scope as it is a minor typo.

I think also you might have justified less important a little incorrectly. I believe it is not of low priority if it causes confusion for the user. Furthermore, it is quite simple to fix this typo. This should not be delayed until future iterations.

Furthermore, in the course website, it states that at least one of the bellow needs to be satisfied: The UG specifies it as not supported or coming in a future version. The user cannot attempt to use the missing feature or when the user does so, the software fails gracefully, possibly with a suitable error message i.e., the software should not crash.

But, this is a minor typo that does not satisfy not in scope.