Open glenngnng opened 9 months ago
A reason why editing of budget doesn't work is because we have a claim budget feature under the command claim INDEX $/-100
for claiming of receipts and claim INDEX $/+100
for allocation of new funds to the claim budget. Henceforth, we decided not to allow editing of budget so that users can use a more intuitive version which is the claim command to alter every individual claim budget. Perhaps you can try out the claim command!
Team chose [response.Rejected
]
Reason for disagreement: Well, I understand the issue.
I have to retract my statement that the user has to delete and add the contact again. However, I think that subtracting and adding from the claim budget (while still achieving the functionality of editing it) will be less efficient if the HR person has added a completely wrong claim budget.
The user of the app would have to calculate the difference between the incorrect and correct claim budget, then subtract/add the difference. I mean, this still achieves the intended outcome, but why completely limit the use of edit too? The user might not catch that edit cannot edit claim budget and still proceed to do so.
This would then hinder the user: They first try to edit, find out they can't edit, proceed to calculate the difference, add/subtract the difference. But an edit feature would be much easier, especially for fast typists. (not mentioning anything about fast calculators here).
In the error message as shown above too, it says edit can be used to edit the employee's details. In the UG, it says edit is used to edit the employee's information. I believe claim budget is also a part of that information/details, given how it has to be added as information when adding an employee. But, the user might be stunned when they see that they are unable to edit claim budget.
Perhaps you could make it a possible option for the HR user to both edit and increment/decrement the claim budget for cases such as these. I believe omitting out the ability to edit does not make it more intuitive as editing and incrementing/decrementing are still different uses. I.e. the HR person incorrectly added the claim budget and only knows what the correct budget should be -> uses edit. The HR person knows how much the employee has claimed -> uses decrement.
In the UG, it is not stated either.
Since it was possible to add a contact with b/ to indicate claim budget, it should be possible to edit the claim budget too.
However, in this case, if the budget was incorrectly input, the user would have to delete the contact and add it in again correctly.