compile errors due to missing parameter in hal/chain/test/blockVizTest.c

[diekhans]

A collaborator is getting the following error trying to compile HAL with or without using progressive cactus. I tried this on hgwdev and it works fine. However, looking at the call, this call is missing the halGetBlocksInTargetRange parameters:

      const char *coalescenceLimitName,
      char **errStr);

I am mystified by it doesn't fail on hgwdev. Please add the required parameters.

make[1]: Entering directory `/home/gbrowse/hal/chain'
h5c++ -prefix=/home/gbrowse/hdf5/ -O3 -g -Wall -funroll-loops -DNDEBUG  -I..//../sonLib/lib -fPIC -DENABLE_UDC -I/home/gbrowse/kent//src/inc -pthread -I inc -I impl -I ../lib/ -I impl -I tests -o test/blockVizTest test/blockVizTest.c ../lib//halChain.a ../lib//halLod.a ../lib//halMaf.a ../lib//halLiftover.a ../lib//halLib.a ..//../sonLib/lib/sonLib.a ..//../sonLib/lib/cuTest.a /home/gbrowse/kent//src/lib/x86_64/jkweb.a  /home/gbrowse/samtabix//libsamtabix.a -lssl -lcrypto
test/blockVizTest.c: In function ‘void* getBlocksWrapper(void*)’:
test/blockVizTest.c:144:42: error: too few arguments to function ‘hal_block_results_t* halGetBlocksInTargetRange(int, char*, char*, char*, hal_int_t, hal_int_t, hal_int_t, hal_seqmode_type_t, hal_dup_type_t, int, const char*, char**)’
                                         1);
                                          ^
In file included from test/blockVizTest.c:5:0:
inc/halBlockViz.h:220:29: note: declared here
 struct hal_block_results_t *halGetBlocksInTargetRange(int halHandle, 
                             ^
test/blockVizTest.c: At global scope:
test/blockVizTest.c:92:13: warning: ‘void printStats(FILE*, int)’ defined but not used [-Wunused-function]
 static void printStats(FILE* file, int handle)
             ^
make[1]: *** [test/blockVizTest] Error 1
make[1]: Leaving directory `/home/gbrowse/hal/chain'
make: *** [all.chain] Error 2

[joelarmstrong]

I think it compiles correctly on hgwdev because the broken code is usually ifdef'd out. Will fix.

[joelarmstrong]

OK, fixed on master branch of both hal & progressivecactus.