glennljs / pe

0 stars 0 forks source link

Duplicate Resident check is Case-Sensitive #6

Open glennljs opened 3 years ago

glennljs commented 3 years ago

The name parameter checks indicate that it must be Unique but does not state whether this uniqueness is case-sensitive.

In this case it is probably conventionally assume to be case-insensitive. For example, "Alex Yeoh" should be matched with "alex Yeoh".

However, the product treats both names as unique and allows adding the duplicates.

Screenshot 2021-04-16 at 14.52.59.png

nus-pe-bot commented 3 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case insensitivity for name of resident

Steps to reproduce: radd n/John Doe p/91234567 e/e0123456@u.nus.edu y/3 radd n/John doe p/91234567 e/e0123456@u.nus.edu y/3

Expected: The name should be treated as case insensitive and be considered repeated entries

Actual: The name parser treats the input as case sensitive. Furthermore, the rfind feature searches for names and is case-insensitive, hence there is an inconsistency and user behaviour unhandled.

Screenshot 2021-04-16 at 2.21.55 PM.png


[original: nus-cs2103-AY2021S2/pe-interim#2795] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Resident names are case insensitive. It can be case sensitive. However, it is low because residents would not have the same name.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]