search

glennmatthews / cot

Common OVF Tool
MIT License
90 stars 23 forks source link

error handling in deploy-esxi broken with requests 2.8 #42

Closed glennmatthews closed 8 years ago

glennmatthews commented 8 years ago 
$ python -m unittest2 discover -p test_deploy_esxi.py
........
----------------------------------------------------------------------
Ran 8 tests in 0.251s

OK
$ sudo pip install requests --upgrade
Collecting requests
  Downloading requests-2.8.1-py2.py3-none-any.whl (497kB)
    100% |████████████████████████████████| 499kB 805kB/s 
Installing collected packages: requests
  Found existing installation: requests 2.7.0
    Uninstalling requests-2.7.0:
      Successfully uninstalled requests-2.7.0
Successfully installed requests-2.8.1
$ 
$ python -m unittest2 discover -p test_deploy_esxi.py
......E.
======================================================================
ERROR: test_serial_fixup_connection_error (COT.tests.test_deploy_esxi.TestCOTDeployESXi)
Call fixup_serial_ports() to connect to an invalid host.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/glmatthe/Documents/OVF_Tools/cot-public/cot/COT/tests/test_deploy_esxi.py", line 207, in test_serial_fixup_connection_error
    self.instance.fixup_serial_ports, 2)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/unittest2/case.py", line 726, in assertRaises
    callableObj(*args, **kwargs)
  File "/Users/glmatthe/Documents/OVF_Tools/cot-public/cot/COT/deploy_esxi.py", line 336, in fixup_serial_ports
    self.username, self.password) as conn:
  File "/Users/glmatthe/Documents/OVF_Tools/cot-public/cot/COT/deploy_esxi.py", line 88, in __enter__
    e.errno = e.args[0].args[1].errno
IndexError: tuple index out of range

----------------------------------------------------------------------
Ran 8 tests in 0.231s

FAILED (errors=1)
$