search

glenpowell / certificate-transparency

Automatically exported from code.google.com/p/certificate-transparency
0 stars 0 forks source link

Add Certificate.serial_number() - patch included #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This exposes the certificate serial_number.

it returns a asn1.CertificateSerialNumber object since it's not really clear 
what format should be returned.   This seems to match how subject-alt-names 
works  (it returns a list of GeneralNames).

However I'd be happy with just returning a single string version of the number 
'12313423423' etc.

Test included.

https://codereview.appspot.com/14025043/

thanks

nickg

Original issue reported on code.google.com by nickgsup...@gmail.com on 27 Sep 2013 at 7:20

GoogleCodeExporter commented 9 years ago 
this is on git HEAD.   ok to resolve.

Original comment by nickgsup...@gmail.com on 1 Oct 2013 at 2:35

GoogleCodeExporter commented 9 years ago 
Forgot to update! Resolved.

Original comment by ekasper@google.com on 1 Oct 2013 at 3:15