glenrobson / SimpleAnnotationServer

A simple IIIF and Mirador compatible Annotation Server
Apache License 2.0
97 stars 28 forks source link

Updated to latest Mirador, including integrated SAE module in Mirador… #13

Closed aeschylus closed 8 years ago

aeschylus commented 8 years ago

… codebase with fix for breaking changes.

To expand:

We recently added some new options to the annotation endpoint that slightly broke the API. We also wanted to integrate several choices for annotation backends into Mirador itself, so we have added an updated SAE module to Mirador itself, as one of several adaptors. This update to SAS will replace the demo page with the newest Mirador version, including this updated adaptor module. Otherwise it is very much the same.

I guess the question is now: should we delete the endpoint adaptor from this repo or update it and have Mirador track the changes from here?

glenrobson commented 8 years ago

Sorry this has taken so long to merge. I did come across one problem which is reported at https://github.com/IIIF/mirador/issues/767. I've fixed it in this version but it means I can't copy over a newer copy of Mirador without re-applying the fix. I'm afraid my limited JavaScript knowledge isn't enough to supply a patch. In this version I just commented out the line.

I've deleted simple annotation endpoint from this project, happy for it to be managed in the mirador one.