search

glensc / dokuwiki-plugin-pageredirect

Redirects page requests based on content
https://www.dokuwiki.org/plugin:pageredirect
19 stars 19 forks source link

Add <br/> tag to the redirect note to avoid being covered by page TOC #4

Closed StephenBrown2 closed 11 years ago

StephenBrown2 commented 11 years ago

The notice for the Redirected page is covered by the automatically generated table of contents. Adding a break tag after the div fixes this.

glensc commented 11 years ago

screenshot would be useful. but merging for now

StephenBrown2 commented 11 years ago

No problem:

Without the<br/>: redirect_note-without_br

With the<br/>: redirect_note-with_br

Though I personally prefer the look of the msg() function: msg(sprintf($this->getLang('redirected_from'), html_wikilink(':'.$page.'?redirect=no',$page))); and msg(sprintf($this->getLang('redirected_from'), '<a href="'.wl(':'.$page, Array('redirect' => 'no'), TRUE, '& ').'" class="wikilink1" title="'.$page.'">'.$page.'</a>')); both appear to do the same thing, the first being more concise and, in my opinion, readable. Why the need for a custom div style at all? Perhaps because of the "This page has moved" notice? But a msg() works fine there too. This may be a separate issue.

glensc commented 11 years ago

dunno. i just imported the code to git so it would be maintainable

StephenBrown2 commented 11 years ago

Gotcha. I'll do a bit of hacking/cleanup on that over the weekend and see what I come up with.

glensc commented 7 years ago

two opinions why custom implementation: