search

glensc / dokuwiki-plugin-pageredirect

Redirects page requests based on content
https://www.dokuwiki.org/plugin:pageredirect
19 stars 19 forks source link

Fix warnings for PHP 8.1, Deprecations in Dokuwiki 2023-04-04a “Jack Jackrum” #47

Closed Miro-Collas closed 5 months ago

Miro-Collas commented 11 months ago
glensc commented 6 months ago

what php version are the fixes for?

Miro-Collas commented 6 months ago

what php version are the fixes for?

8, as noted in the PR title

glensc commented 6 months ago

8 has many versions already by now: 8.0, 8.1, 8.2, 8.3, maybe even 8.4

nerun commented 6 months ago

If you click the links provided by author: Undefined array key action.php line 74 (with FIX) #44 you will see that fix was tested for PHP 8.1. It's always recommended to analyze the changes in the code a PR do too. The undefined array key fix uses array_pad, that works since PHP 4, as you can see here: PHP: array_pad - Manual. There's no reason to it don't work in ANY PHP 8 version: 8.1, 8.2, 8.3, 8.4...

The other one is a DokuWiki deprecation warning. It is how things works for DokuWiki 2023-04-04a “Jack Jackrum”. You don't need to accept it since a warning is not a bug. But a deprecation warning is an advise that the "old way" will stop working sometime in the future.

Miro-Collas commented 6 months ago

8 has many versions already by now: 8.0, 8.1, 8.2, 8.3, maybe even 8.4

Yes, 8.1 - thanks @nerun :-)

glensc commented 5 months ago

it's not maintainers' job to click around to find info. should be filled in pr body: pr should be standalone describing it's changes.

Miro-Collas commented 5 months ago

Thank you.