search

glensc / nagios-plugin-check_raid

Nagios/Icinga/Sensu plugin to check current server's RAID status ⛺
144 stars 84 forks source link

Arcconf: don't mix drives with logical devices #140

Closed fabricat closed 7 years ago

fabricat commented 8 years ago

In the status line you are pushing some strings like the following one:

Failed/Degraded/Offline/etc drives:$c->{logical_failed/degraded/offline/etc}

Isn't this a bit confusing? We are talking about logical devices, and not physical drives. I'd suggest to replace the descriptive string.

Moreover the message "Degraded drives" appears twice!!!

glensc commented 8 years ago

please see CONTRIBUTING.md and provide test data.

glensc commented 7 years ago

Unable understand what he talks about; No test data; No output; No code references; Nothing.

fabricat commented 7 years ago

I'm sorry for the late response.

The code I was talking about is in /lib/App/Monitoring/Plugin/CheckRaid/Plugins/arcconf.pm, raw 495 The "failed drives" strings makes me think to a physical drive, not a logical device. I would change it to "failed logical devices" and, if it is available, would add a physical HDDs status report.

About the duplicate degraded report, I've seen ti has been already fixed here.

Thank you.