search

glensc / nagios-plugin-check_raid

Nagios/Icinga/Sensu plugin to check current server's RAID status ⛺
144 stars 84 forks source link

Improve arcconf support #210

Closed carnil closed 2 years ago

carnil commented 2 years ago

This is based on the work done in https://github.com/glensc/nagios-plugin-check_raid/pull/208

Add a new test case as output from a arcconf call in version 3.10.00.

Some new sections are added which are not (yet) parsed. This might be useful to expand in a further step.

The parsing accounts as well for other output formats for reported locations when a device is 'Enclosure Direct Attached'.

glensc commented 2 years ago

@carnil is the PR ok from your side? The CI is missing since Travis ditched projects.

carnil commented 2 years ago

@carnil is the PR ok from your side? The CI is missing since Travis ditched projects.

@glensc the testsuite for the arcconf passes:

t/check_arcconf.t .. ok       
All tests successful.
Files=1, Tests=129,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.13 cusr  0.00 csys =  0.14 CPU)
Result: PASS

and a quick check (on a known good RAID) passes directly with the fatpacked check_raid.pl.

carnil commented 2 years ago

That said, it would be nice to add more support for the now skipped sections probably, but I initially focused on try to make check_raid working with the extended output.