glest / glest-source

Glest is a network multi-player cross-platform 3D real-time strategy (RTS) game, where you create armies of units and battle different factions.
https://glest.io
GNU General Public License v3.0
56 stars 39 forks source link

upgrade embedded libircclient from 1.3 to 1.10 #207

Closed andy5995 closed 5 years ago

andy5995 commented 5 years ago

This upgrades libircclient, a 3rd party library, from 1.3 to 1.9.

It removes some win32 related files that were under shared_lib/sources/libircclient, so I don't think that will affect anything @mathusummut has done with the win build.

It removes many, many apparently unneeded files.

The includes for libircclient have been moved. Before they were separated into https://github.com/ZetaGlest/zetaglest-source/tree/develop/source/shared_lib/include but what I did was edit the CmakeLists.txt file so they would be looked at in the source/libircclient directory. Basically they are now in the same location as the libircclient distribution as it was released by the maintainers.

andy5995 commented 5 years ago

Oh, the ChangeLog for libircclient can be viewed at https://github.com/ZetaGlest/zetaglest-source/pull/207/files#diff-2a35002207d9e074987b668f273e598d

andy5995 commented 5 years ago

Failing travis osx build right because it can't find libircclient. I checked at https://formulae.brew.sh/formula/ and it's apparently not available.

I'll ask around. If anybody knows of a good solution, please let us know. cc @jamjamdev @rlyshw

andy5995 commented 5 years ago

I think using brew with another tap will work. That's a tap @sexybiggetje set up for one of my projects.

https://travis-ci.org/ZetaGlest/zetaglest-source/jobs/425840567#L1477

I added libircclient to it. Looks like it installed but now it's just a matter of telling ZG where to find the libs.

andy5995 commented 5 years ago

Decided to upgrade it instead of removing it. There were some problems with building and installing from source.

https://sourceforge.net/p/libircclient/bugs/27/

https://sourceforge.net/p/libircclient/bugs/18/