glest / glest-source

Glest is a network multi-player cross-platform 3D real-time strategy (RTS) game, where you create armies of units and battle different factions.
https://glest.io
GNU General Public License v3.0
56 stars 39 forks source link

In some cases, when multiple barracks are selected, produce option should remain disabled #245

Closed andy5995 closed 5 years ago

andy5995 commented 5 years ago

Related to #218

If 2 or more barracks are selected, the option to produce is enabled even when there's only enough cash for one unit to be produced. The option should remain disabled, unless he has enough cash to produce from all the selected barracks.

andy5995 commented 5 years ago

The problem as I see it, is that if I have 4 barracks selected and the option is enabled, I still have to check my resources, to see how many I can produce, and then do the math in my head to know how much I need to produce 1 unit from each barracks I have in my selection group. I don't feel it's logical or intuitive to show it enabled just because I have enough cash to produce 1. And it's not obvious to the player that it shows as enabled even if they don't have enough cash to actually build 4 if they have 4 barracks selected.

That's why I think it would be better to have it remain disabled, so a player can decide to deselect all but 1 of his barracks, or do something else and then re-select the group. (I'm usually using ctrl-grouping in this case).

So basically, I'm finding this true for me

That would make giving commands slower and more annoying.

So if you feel the opposite, we must have different ways of producing, or you're better at doing math in your head ;)

joaomarcoscsilva commented 5 years ago

Alternatively, we can show the number of units that will be created next to (or inside) the icon. Even though it's not as easy, we can reuse the code we make for #202.

andy5995 commented 5 years ago

This is what that looks like in 0 A.D.

screenshot_2018-09-27_15-59-07

joaomarcoscsilva commented 5 years ago

What do you mean? It would just be a visual interface change. And even if we implement batch-training, not using it should work as usual.

joaomarcoscsilva commented 5 years ago

Oh ok XD