glest / glest-source

Glest is a network multi-player cross-platform 3D real-time strategy (RTS) game, where you create armies of units and battle different factions.
https://glest.io
GNU General Public License v3.0
56 stars 39 forks source link

VLC-related code and files can be removed #257

Closed andy5995 closed 5 years ago

andy5995 commented 5 years ago

Using vlc for videos was something that was never fully implemented. The code and related files can be removed.

This output from git grep should provide some hints as to what files are affected:

https://gist.github.com/andy5995/52d91440ca078b05500871c384928fdf

mukeshmk commented 5 years ago

I want to work on this issue.

But before I can start, I have a question. I was just going through the code. I wanted to know the functionality of video_player.h and video_player.cpp, this would help me a little. They are being used in the code in a few places. And also are there any other video players apart from VLC?

Thanks in advance.

andy5995 commented 5 years ago

Thank you for your interest @mukeshmk . I'll review the code some more and provide you with some specifics within a few days.

mukeshmk commented 5 years ago

Thanks, @andy5995 , I just wanted to know if you have any updates for me?

andy5995 commented 5 years ago

No, not yet. @mathusummut is something you wanted done?