glfw / glfw.github.io

Jekyll sources for GLFW website
https://www.glfw.org/
Other
28 stars 19 forks source link

Mobile fixes and basic SEO #71

Closed siavashserver closed 4 years ago

siavashserver commented 4 years ago

Hello, here is couple a of changes I made to improve the website performance on mobile devices, and hopefully make it more search engine friendly 🔥🔥🔥

Important note: Please make sure that JEKYLL_ENV=production environment variable has been set before running production builds, otherwise jekyll-seo-tag and jekyll-minifier plugins will fail to perform their magic correctly.

Better responsive design on small screens and mobile devices:

Common search engine optimizations:

Addresses #70 .

elmindreda commented 4 years ago

Thank you! Modulo the minifier this also should bring us several steps closer to being able to build on GitHub Pages.

I noticed that with these changes the lead text can get very close to the buttons for some widths 1

Also the example code in documentation.md is now very narrow on mobile, seemingly because we lost figure{margin:0} 2

siavashserver commented 4 years ago

Nice catch, should be fixed now. 👍

siavashserver commented 4 years ago

We can easily drop the less and therubyracer plugins as well by switching to sass for our stylesheets.

Going to queue another commit to replace them.

siavashserver commented 4 years ago

I think it should be ready now.

elmindreda commented 4 years ago

Thank you so much!

siavashserver commented 4 years ago

You are welcome 😊

On Fri, Sep 4, 2020, 4:47 AM Camilla Löwy notifications@github.com wrote:

Thank you so much!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/glfw/website/pull/71#issuecomment-686828270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIGT2TL4VUBGVSOWZFFDR3SEAW3NANCNFSM4QPTUSJA .