Closed siavashserver closed 4 years ago
Thank you! Modulo the minifier this also should bring us several steps closer to being able to build on GitHub Pages.
I noticed that with these changes the lead text can get very close to the buttons for some widths
Also the example code in documentation.md is now very narrow on mobile, seemingly because we lost figure{margin:0}
Nice catch, should be fixed now. 👍
We can easily drop the less
and therubyracer
plugins as well by switching to sass
for our stylesheets.
Going to queue another commit to replace them.
I think it should be ready now.
Thank you so much!
You are welcome 😊
On Fri, Sep 4, 2020, 4:47 AM Camilla Löwy notifications@github.com wrote:
Thank you so much!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/glfw/website/pull/71#issuecomment-686828270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIGT2TL4VUBGVSOWZFFDR3SEAW3NANCNFSM4QPTUSJA .
Hello, here is couple a of changes I made to improve the website performance on mobile devices, and hopefully make it more search engine friendly 🔥🔥🔥
Important note: Please make sure that
JEKYLL_ENV=production
environment variable has been set before running production builds, otherwisejekyll-seo-tag
andjekyll-minifier
plugins will fail to perform their magic correctly.Better responsive design on small screens and mobile devices:
Common search engine optimizations:
jekyll-seo-tag
plugin to automate SEO process.description
attribute to all pages.jekyll-minifier
plugin to automate output minification process.Addresses #70 .