search

glguy / tries

BSD 3-Clause "New" or "Revised" License
11 stars 8 forks source link

relax upper bound on base #20

Closed ocramz closed 1 year ago

ocramz commented 3 years ago

Addresses #19

treeowl commented 1 year ago

This PR should probably be updated to relax the bound further. @glguy, do you need someone else to take over this package?

glguy commented 1 year ago

This PR should probably be updated to relax the bound further. @glguy, do you need someone else to take over this package?

I'd be happy to hand it over. It's been off my radar for some time. Are you interested?

ocramz commented 1 year ago

I'd be happy to help out too. It's the fastest trie library I've benchmarked and would be a pity to let it bitrot

On Tue, 11 Oct 2022 at 19:58, Eric Mertens @.***> wrote:

This PR should probably be updated to relax the bound further. @glguy https://github.com/glguy, do you need someone else to take over this package?

I'd be happy to hand it over. It's been off my radar for some time. Are you interested?

— Reply to this email directly, view it on GitHub https://github.com/glguy/tries/pull/20#issuecomment-1275072277, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNBDKBBGRUVLJSFR57ERK3WCWTFXANCNFSM46ZDNFDQ . You are receiving this because you authored the thread.Message ID: @.***>

treeowl commented 1 year ago

I'd be interested in co-maintaining it.

glguy commented 1 year ago

I'd be interested in co-maintaining it.

OK, I've added you on hackage and this repository. Welcome!

treeowl commented 1 year ago

Thanks!

ocramz commented 1 year ago

@glguy could you add me as a maintainer as well please?

treeowl commented 1 year ago

Relaxing upper bounds should ideally include some changes around StarIsType. Probably just a few minutes. And someone needs to set up CI. There are no tests yet, but even making sure it compiles on everything it should would be nice.

treeowl commented 1 year ago

I bumped everything in #25, and cleaned up some build failures and so on in #27.