search

glhd / gretel

Laravel breadcrumbs right out of a fairy tale
MIT License
243 stars 16 forks source link

PHP 8.1 Fix BreadcrumbIterator.php #6

Closed OneForTheCode closed 2 years ago

OneForTheCode commented 2 years ago

ArrayIterator fix for php 8.1 instead of suppressing the errors.

Tested on debian 11, CentOS 7/8 and Cloudlinux 7 with php 8.1.6 and php 8.1.5

inxilpro commented 2 years ago

Does the ReturnTypeWillChange attribute cause an issue for you in PHP 8.1? The plan is to keep it there until we drop support for PHP 7.4.

OneForTheCode commented 2 years ago

Not really, other then spamming log file about it (in debug mode). But php 7.4 active support is already 6 months EOL, and 6 more months to go for security updates. So if people still haven't updated to at least php 8.0 they will not do so in the 6 upcomming months i think. Either way i fixed it on my own projects in the vendor directory, just have to watch out when i auto update via composer.

inxilpro commented 2 years ago

I'm going to leave this until we officially drop PHP 7.4 support. That will probably happen pretty soon, though!