search

glicol / glicol-cli

glicol cli: cross-platform music live coding in terminal
https://github.com/chaosprint/glicol
MIT License
139 stars 12 forks source link

Apply fixes recommended by Clippy #28

Closed itsjunetime closed 6 months ago

itsjunetime commented 6 months ago

This PR does a few things:

  1. Applies the fixes recommended by clippy. Involved in this was extracting most of the Atomics to being held in a SampleData struct, which is then wrapped in an Arc to avoid allocating an Arc per-Atomic. This fixes clippy's complaint about over-complicated/too many fn arguments
  2. Update ahash (to not use the yanked version) and remove some unused features in dependencies
  3. Move the terminal setup code to after the initial audio device configuration, to prevent a situation where the terminal is setup and then the program crashes, putting the terminal in a weird state.
chaosprint commented 6 months ago

LGTM