search

glideapps / glide-data-grid

🚀 Glide Data Grid is a no compromise, outrageously react fast data grid with rich rendering, first class accessibility, and full TypeScript support.
https://grid.glideapps.com
MIT License
4.03k stars 292 forks source link

Touch doesn't execute header menu on mobile #806

Open mjpolak opened 11 months ago

mjpolak commented 11 months ago

Reproduction:

  1. Go to https://grid.glideapps.com/ on mobile device
  2. Try to click on header menu

Result

The menu doesn't open

Expected result

Menu is visible

tanvirraj commented 10 months ago

@jassmith , @mjpolak i try to reproduce this issue in safari iOS, i found that this menu is not working in iOS, is this right, then i can look into this one

Screenshot 2023-12-18 at 12 48 44 PM
jassmith commented 10 months ago

It would be great if you could poke at it. The solution here is that the onHeaderMenuClick event needs to emit when there is a long touch (and the other requirements for emitting this event are met). Fortunately the base implementation already tells you if the last interaction was a long touch, so this shouldn't be too hard.

tanvirraj commented 10 months ago

make sense. Thanks for brief intro. will look into this.