search

glideapps / glide-data-grid

🚀 Glide Data Grid is a no compromise, outrageously react fast data grid with rich rendering, first class accessibility, and full TypeScript support.
https://grid.glideapps.com
MIT License
3.81k stars 275 forks source link

Row grouping modules missing in package #958

Open theiliad opened 1 month ago

theiliad commented 1 month ago

I've noticed that a lot of modules related to row-grouping don't seem to be included in 6.0.3 release, not sure if previous releases did in fact include those

For instance these files

image

and

image

are missing from final build https://unpkg.com/browse/@glideapps/glide-data-grid@6.0.3/src/data-editor/

I'm also seeing type warnings suggesting that this feature might not actually be in the package image

Also I'm not able to see any results after pulling all those modules into my local codebase, and adding rowGrouping to my grid

Is this in fact an issue?

citizensas commented 1 month ago

If it helps, it is available in the latest alpha 6.0.4-alpha8 release.

theiliad commented 1 month ago

If it helps, it is available in the latest alpha 6.0.4-alpha8 release.

I see, so not stable yet?

snowy-owll commented 1 month ago

I see, so not stable yet?

I couldn't get the row grouping to work correctly. It looks like there are problems with calculating the original row indexes in groups.

mirus-ua commented 1 month ago

I see, so not stable yet?

I couldn't get the row grouping to work correctly. It looks like there are problems with calculating the original row indexes in groups.

We are playing a bit with the grid for our POC, and here is a potential solution for your problem if it's the same as ours const item = data[isGroupHeader ? originalIndex[1] : row];

snowy-owll commented 1 month ago

We are playing a bit with the grid for our POC, and here is a potential solution for your problem if it's the same as ours const item = data[isGroupHeader ? originalIndex[1] : row];

@mirus-ua Yes, I know about this. It helps with collapsing rows, but it returns a little wrong index. Even their example doesn't show all the data. It should display 1000 rows, but the last row index is 995. So, every group "eats" one row.